Paul Gooderham

Results 18 comments of Paul Gooderham

Modifying the messages and locations requires updates in liberty-tools-intellij https://github.com/OpenLiberty/liberty-tools-intellij/issues/453

Externalized messages for diagnostics and quick fixes but not snippets.

Adding @Resource causes a diagnostic which uses ScopeDeclarationQuickFix. This quick fix uses diagnostic.getData() which returns null and causes the NPE. Caused by https://github.com/microsoft/vscode/issues/181166

We made a fix related to this, the one that fixed the package name and class name of a snippet. Could you ensure you are using the latest lsp4jakarta?

I just saw the pull request that included the last few tests. It looks like all the tests have been addressed.

The same applies with `@AssertFalse` in MethodConstraintValidation.java. This has invalid type and is static.

Actually if you spell it `@PostiveOrZero` it does not compile but the diagnostic and quick fix are generated.

c.f. https://github.com/OpenLiberty/liberty-tools-intellij/issues/781