lsp4jakarta
lsp4jakarta copied to clipboard
Add unit tests for certain quick fixes
There are unit tests for some quick fixes but there are none for the following diagnostics.
Bean Validation
- The
@DecimalMax/@DecimalMin/@Digitsannotation can only be used on: BigDecimal... etc. - The
@Emailannotation can only be used on String... - The
@Min/@Maxannotation can only be used on BigDecimal, ... etc - The
@Negative/@NegativeOrZero/@Positive/@PositiveOrZeroannotation can only be used on BigDecimal, ... etc - The
@NotBlank/@Patternannotation can only be used on String and CharSequence type fields or methods.
WebSocket
- A unit test exists for inserting the
@PathParamannotation on to method parameters but does not verify all the code actions for all the diagnostics produced by the test resource. Seeio.openliberty.sample.jakarta.websocket.AnnotationTestandorg.eclipse.lsp4jakarta.jdt.websocket.JakartaWebSocketTest.addPathParamsAnnotation(). The test should also verify the quick fixes for thepublic void OnClose(Session session, Integer missingAnnotation1, String missingAnnotation2)method.
Contains more test cases for
- [x]
FutureandFuturePresentAnnotation Quick fix test cases - [x]
PastandPastOrPresentAnnotation quick fix test cases
I just saw the pull request that included the last few tests. It looks like all the tests have been addressed.
I just saw the pull request that included the last few tests. It looks like all the tests have been addressed.
All the annotations mentioned are addressed and tested.