eclipse.platform.ui icon indicating copy to clipboard operation
eclipse.platform.ui copied to clipboard

[WiP] Use WorkspaceTestRule in UITestCase #291

Open HeikoKlare opened this issue 1 year ago • 1 comments

⚠️ This is not to be merged. It is currently only supposed to provide an overview of side effects when applying the general WorkspaceTestRule for uniform workspace cleanup after test execution to all UITestCase implementations. ⚠️

All specializations of UITestCase operate on a workspace, for which the JUnit 4 WorkspaceTestRule exist to ensure proper workspace cleanup, including deletion of all projects and restoring workspace default settings. Currently, such cleanup is up to the individual test case and not performed uniformly and consistently.

With this change, the WorkspaceTestRule is applied to all specializations of WorkspaceTestRule. As a first direct application, the manual project deletion in ResourceInitialSelectionTest, which is currently failing randomly, is removed and replaced by the general cleanup functionality.

May fix https://github.com/eclipse-platform/eclipse.platform.ui/issues/294

HeikoKlare avatar Apr 29 '24 18:04 HeikoKlare

Framework for both Jakarta LS and Jakarta JDT LS components:

  • Externalize all strings to a separate properties file
  • Create a class to define APIs for loading language files, getting actual messages from their keys, formatting the messages with multiple variables etc.

One thing unknown:

We are using JSON file for code completion in Jakarta LS, messages and action details are all defined there, we need a way to handle those messages differently

bensonnw avatar Aug 25 '22 21:08 bensonnw

Loading JSON files:

  1. JakartaEESnippetRegistryLoader loads each JSON file and adds the contents to SnippetRegistry
  2. SnippetRegistry.getCompletionItem(...) to create org.eclipse.lsp4j.CompletionItem object for code completion

bensonnw avatar Aug 29 '22 20:08 bensonnw

New issue open to address creating the Java framework for globalization: https://github.com/eclipse/lsp4jakarta/issues/315

This issue will focus on adding the JSON piece of the framework and externalizing existing strings.

TrevCraw avatar Sep 01 '22 15:09 TrevCraw

Modifying the messages and locations requires updates in liberty-tools-intellij https://github.com/OpenLiberty/liberty-tools-intellij/issues/453

turkeylurkey avatar Jun 15 '23 20:06 turkeylurkey

Externalized messages for diagnostics and quick fixes but not snippets.

turkeylurkey avatar Jun 27 '23 22:06 turkeylurkey