Tung D. Le

Results 141 comments of Tung D. Le

Alex, thank you for looking at this! I am thinking of a simple solution that can be quickly implemented. In `rewrite-onnx-for-zhigh`, when we expand `Add`, if we detect that the...

> Is this default behavior or enabled via switch? Yes, it's on by default. Let me know if you want a switch or set it off.

> onnxmlirrun.RunONNXModel.onnxmlirrun My two cents here. For the package name (the first onnxmlirrun), just `onnxmlir` is enough to avoid typing two Rs. I would remove `RunONNXModel`, but it seems not...

I am not the original author of that but we can refer to this MLIR document to understand what it is: https://mlir.llvm.org/docs/TargetLLVMIR/#c-compatible-wrapper-emission

> But in fact, in the llama2 v7 7B onnx, op type of /model/Mul_1 is Mul, Could you check if the inputs of Mul are constants? I am thinking whether...

> If I want to aggregate the elapsed time for each operation type, should I include the elapsed time of "/model/Mul_1" under the "Mul" operation type, the "Constant" operation type,...

@jorickert could you update this PR with the latest main branch so that we can merge it? Somehow I cannot do it.