Fix crash in ReshapeOp inference when an input to the previous concat is not a valid dimension

[jorickert]

The problem was that the check:

if ((getShape(vType)[0] == 1) && getElementType(vType).isSignlessInteger(64))
    return true;

can succeed even if areDims(Value val) is not true for all operands of Concat.

This causes a crash in getDims, which recursively calls getDims on all operands of Concats, without checking if these operands are dims.

[jenkins-droid]

Can one of the admins verify this patch?

[tungld]

@jenkins-droid test this please

[tungld]

@jorickert could you update this PR with the latest main branch so that we can merge it? Somehow I cannot do it.

[jorickert]

@jorickert could you update this PR with the latest main branch so that we can merge it? Somehow I cannot do it.

I will on Monday

[jenkins-droid]

Can one of the admins verify this patch?

[tungld]

@jenkins-droid test this please

[AlexandreEichenberger]

@jorickert do you want this PR to be merged? Let us know and we will merge it.

[jorickert]

@AlexandreEichenberger Yes, please merge

[AlexandreEichenberger]

@jorickert Thanks for your contributions, much appreciated.

[jenkins-droid]

Jenkins Linux amd64 Build #15078 [push] Fix crash in ReshapeOp i... started at 13:58

[jenkins-droid]

Jenkins Linux s390x Build #15083 [push] Fix crash in ReshapeOp i... started at 14:58

[jenkins-droid]

Jenkins Linux ppc64le Build #14108 [push] Fix crash in ReshapeOp i... started at 15:09

[jenkins-droid]

Jenkins Linux amd64 Build #15078 [push] Fix crash in ReshapeOp i... passed after 1 hr 7 min

[jenkins-droid]

Jenkins Linux s390x Build #15083 [push] Fix crash in ReshapeOp i... passed after 1 hr 25 min

[jenkins-droid]

Jenkins Linux ppc64le Build #14108 [push] Fix crash in ReshapeOp i... passed after 1 hr 58 min