Tony Barnes

Results 10 comments of Tony Barnes

Looking forward to having this merged 😄

i'm getting the same issue. Any help please? Sounds like the API needs to allow * access, otherwise introduce API keys?

+1, it doesn't seem possible to use a localhost https with ngrok, with the free plan at least 😢 I've gone through other related github issues and tried the suggestions...

@trevanhetzel Like this? http://jsfiddle.net/mhb6p6zt/13/show/ So clicking one of the links would allow default behaviour. eg: example.html#test6 I've got some code ready that also prevents default if a tab link only...

I came across the same issue. You need to include it in the `makeController` function, like this: ``` makeController = () => { return new myController(myService); }; ```

@samithaf ? The code above is using the component controller. Also, I don't understand what you have updated, there's no recent commits from you.

@samithaf Sorry if i'm misunderstanding something, but I can't see how this is related. This issue is about injecting a service into a controller, and unit testing it. In fact,...

@pziegler @samithaf Yes, the confusion has been that @calemyers723 wasn't sure how to **inject** a service into a unit test. Mocking a service is great, but you can also inject...

Really great insights everyone, thank you so much. For anyone else like me stumbling across the issue.... RE allowing the modal to be read out by screenreaders/voiceover, whilst the body...

Will look forward to seeing dependency-free version. With vanilla JS it could be wrapped for use with for example Angular, React.