react-modal-dialog icon indicating copy to clipboard operation
react-modal-dialog copied to clipboard

Published 20 hours ago • verified publisher icon qimingweng

Bump to React 16

Open SandroMachado opened this issue 6 years ago • 9 comments

This PR adds support to React 16.

SandroMachado avatar Oct 16 '17 15:10 SandroMachado

Hi @qimingweng , if you could accept this PR would be very nice!

Thank you and thank @SandroMachado !

rafaeleyng avatar Oct 26 '17 17:10 rafaeleyng

Until this PR gets merged I have forked this repo and committed the built library so it can be used as a dependency. You can use it by changing the relevant line in your package.json to

"react-modal-dialog": "Dean177/react-modal-dialog#support\/bump-react",

Dean177 avatar Oct 30 '17 10:10 Dean177

This package also depends on react-center-component. Same author, and all the same problems. That package also should be updated to make react-modal-dialog usable with react@16.

jeron-diovis avatar Feb 16 '18 10:02 jeron-diovis

@Dean177 what is blocking this PR from merge?

SandroMachado avatar Feb 16 '18 11:02 SandroMachado

No idea, I think you want @qimingweng rather than me though.

Dean177 avatar Feb 16 '18 12:02 Dean177

@qimingweng hey, man! we would love to see this PR already!

ilyadoroshin avatar Feb 20 '18 10:02 ilyadoroshin

Could also use this merged. Thanks!

pippinlee avatar Mar 12 '18 13:03 pippinlee

Looking forward to having this merged 😄

ttbarnes avatar Apr 22 '18 08:04 ttbarnes

bump can @qimingweng please merge!

ali-aka-ahmed avatar Jul 05 '19 16:07 ali-aka-ahmed