Thomas Schoffelen

Results 65 comments of Thomas Schoffelen

I understand the logic for not adding any new brand icons, but I'd be against removing the current ones from the package. They fit in really well with the design...

It is not able to conditionally check for updated files, but you can specify a pattern. Ie. `/*` will match all files.

Really appreciate your contribution! I haven't had time to test this yet, and might not for a while, but happy to merge this into master if you feel confident?

This is definitely a super interesting one! I don't think we do anything special when it comes to saving the JSON payload, we just json_encode it and save the file....

Closing this for now as the associated PR was closed. Feel free to re-open if there's still interest in this functionality!

Closing this for now - I've updated the acceptance test to run as a requirement before the merge can succeed (using the `merge_group` trigger in the GitHub Actions Workflow). Hopefully...

I wouldn't do that, as they indeed might change quite frequently. Would also make the process to add new icons more time-consuming, and the API response longer.

Hi @usamajamil213 - thanks for opening an issue. Have you managed to try the debugging steps [listed the README](https://github.com/includable/php-pkpass?tab=readme-ov-file#debugging-passes)? If you share the error messages the console shows here, we...

From that error, it looks like you might not be using the right certificate for the team identifier you specified: > Pass Viewer Invalid data error reading pass pass.com.qrcampaign.qrwallet/533433-965-259. The...

Closing for now, as this seems to be an implementation specific issue.