Thomas Schoffelen

Results 65 comments of Thomas Schoffelen

Seems like you have commented out the `socket.write()` statement, which means no data is sent at all through the socket at the moment.

You might want to look into using a module like [async](https://github.com/caolan/async) (`npm install --save async`), especially its [`map`](http://caolan.github.io/async/docs.html#.map) function, which basically handles all the looping and checking for you.

If anyone is looking for a quick fix for your clients, adding this somewhere in your template will fix it. See my PR for more details on why that helps....

Hi @nicolasdevienne! Happy to accept a PR to make the `defaultEmailLabel` customisable!

You can't push directly to this repository - you'd push to your own fork, then create a PR. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

This is really cool!

The library includes native Java code to provide the functionality on Android, which isn't supported in Expo Go, unless you build the app yourself (development builds is what Expo calls...

Hi there - this might be related to https://github.com/includable/php-pkpass/pull/124 Do you have the latest version of the library?

I think it's more about PHP not supporting that legacy mode of OpenSSL yet. The workaround in #124 aims to execute the `openssl` executable directly using `shell_exec()`, but this might...

No indeed, legacy mode needs to be used. There are two ways to do that: 1. Tweak openssl configuration as described in the link you shared 2. Run the `openssl`...