react-native-email-link icon indicating copy to clipboard operation
react-native-email-link copied to clipboard

Published 20 hours ago • verified publisher icon includable

Support RN new arch

Open huextrat opened this issue 2 years ago • 2 comments
trafficstars

This PR adds support for both new and old architecture.

This change is Android only, since only Android requires native dev for opening mail through an intent.

Suggestions / Discussions

  • [ ] Make naming clearer (ex: EmailPackage -> RNEmailPackage, EmailImpl -> RNEmailImpl, Email.java -> RNEmail.java)

⚠️ This change needs to be tested on several versions of RN with both architecture.

  • I've tested it on RN 0.72.4 with both old and new arch.

huextrat avatar Aug 25 '23 11:08 huextrat

Really appreciate your contribution! I haven't had time to test this yet, and might not for a while, but happy to merge this into master if you feel confident?

tschoffelen avatar Sep 09 '23 13:09 tschoffelen

It would be better if someone take a look at the changes and did at least one old arch / new arch test to make sure everything is working

huextrat avatar Sep 14 '23 06:09 huextrat