Trustin Lee

Results 271 comments of Trustin Lee

It doesn't prevent a user from completing the returned future anyway. If it's passed to some other component, then we have the same problem, and I'd like to avoid using...

Also, we can create a singleton `UnmodifiableFuture` that's been completed with `null` and reuse it in many places, which is a GC-wise win.

Not in Java 8, because it's added in 9. :sob: (It's also less verbose to call `.join()` or `.get()` because minimal stage must be converted to future.)

Gentle ping :wink:

I'm not sure if this is a good idea given that the primary purpose of this plugin is to use the detected architecture to load .dll or .so. If we...

I see. Sounds like a good idea to have an option for that, probably from a configuration like [this](https://github.com/trustin/os-maven-plugin/issues/20#issuecomment-774410886).

Sorry for a late reply. Would you mind sharing the project repository so I can reproduce the problem?

Tried to get this work somehow, but couldn't figure out yet. It seems like profiles are activated even before the extension is executed. I also tried property-based activation, but it...

I'm not sure what you mean. Could you elaborate a little bit more? oss-parent is a pom-only project and it's available in Maven central.