Trustin Lee

Results 271 comments of Trustin Lee

Could also integrate with AssertJ and Kotlin/Scala assertions.

That's a great idea, @j-min5u. I wonder if the content of the .proto file is already available somewhere inside the generated class though. If that's the case, we probably don't...

@amitvc Here we're gonna have to implement a `X509ExtendedTrustManager` that delegate the check to `ClientTrustManagerAction.checkServerTrusted()` for a given domain name. We need to implement various `ClientTrustManagerAction`s as defined in its...

We may want to reuse the existing `TrustManager` implementations like `InsecureTrustManagerFactory` or `FingerprintTrustManagerFactory` as you mentioned, by delegating the check to them in our action implementations.

Sorry for a late reply, @amitvc. `this.action(String hostnamePattern, ClientTrustManagerAction action)` is a method that allows a user to register any action for a given hostname pattern (`*.armeria.dev`). Internally, you will...

@amitvc I guess there are no unit tests related with this functionality yet. You could just add `ClientTrustManagerTest` and put your tests there.

Gentle ping, @heowc 🙇

Looking forward to progress in this PR ❤️