Trustin Lee
Trustin Lee
> If the decorator completely intercepts, none of the gRPC logic runs, including possibly important ones like server call interceptors. That may be the intention of a user. A decorator...
I wonder if it's a better idea for us to provide an easy way to write a gRPC interceptor. gRPC-Java's interceptor API isn't the best API to implement simple logic...
I think it's not intended. Needs to be fixed ðŸ˜
Thanks, @octo47 for your feed back. I didn't know `ServerInterceptor` is synchronous 😱 (Just double checking, is it true, @anuraaga ?) If that's the case, it sounds like it makes...
@kezhenxu94 Sorry about the conflicts since your last commit here. Please feel free to let us know if you need any help with catching up the recent changes in master....
Updated the milestone since it's not fixed yet.
If we log the counter message, we could uncount the uncaught exceptions whose `ctx.shouldLogUncaughtException` is `false` to make the counter log message disappears when all ervices are covered by `LoggingService`...
@eisig This is huge! General design looks good to me. Please ping us when you think it's ready for review or you have any questions.
@eisig How's this PR going? Anything we can help you with?
Hey @franz1981, I didn't have time for looking into this. Are you asking this because you're using Armeria or the outcome of this issue could be useful to Netty as...