Trustin Lee comments

Results 271 comments of


                                            Trustin Lee

[Idea] Use Pkl for Armeria configuration

I'm somewhat concerned about introducing a new language people are not familiar with. Maybe we should consider YAML, or does Pkl also have YAML support?

[Idea] Use Pkl for Armeria configuration

I'm just exploring, too. :smile: I think it will be useful to have some official YAML configuration that's loaded by Armeria, which could provide an alternative to Java system properties.

Bump send and express in /docs-client

@dependabot rebase

Expose response headers in `DocsService`

Would you mind share the screenshot or screencast that demonstrates the change for easier reviews?

Provide a way to send a JSON object with `WebClient`

+1 to having `HttpRequest.ofJson()` as well.

How about letting `ClientBuilder` expose `io.grpc.Channel`?

Maybe we could refactor `ArmeriaChannel` so that it's capable of having different marshallers for different stub types? Could use weak-key map to avoid leak (if that's gonna be a problem)

Bump body-parser and express in /docs-client

@dependabot rebase

Bump path-to-regexp and express in /docs-client

@dependabot rebase

Do you have plan to provide support for openFeature?

Hi! Central Dogma is very often used as a feature flag service in real life and it's one of its intended usage. Therefore, I agree that it'll be nice to...

Bump dompurify and mermaid in /docs-client

@dependabot rebase