Trustin Lee

Results 271 comments of Trustin Lee

Thanks for the input, @chrisvest. That's also a feasible option. Let me stay tuned to what Reactor maintainers think. Once agreed, I'd be happy to send out a PR.

Thanks for the reply, @chemicL. Your suggestion sounds good to me. Let me try to find some time to make a contribution. :bow:

Hey, thanks a lot for reporting the problem. If I understood correctly, you want the `CorsService` to inject the CORS response headers even to the error responses generated by `ServerErrorHandler`,...

Here's the idea: - Improve `CorsConfig` API so that a user can build it with a builder API, e.g. ```java var myCorsCfg = CorsConfig.builder()....build(); ``` - Allow a user to...

Yeah, `orElse()` doesn't achieve what you want as you mentioned. The ability to decorate a `ServerHandler` with another is something we need to implement as well. For now, your Kotlin...

Because I have only one share, I can specify the aforementioned properties in the `global` section in `config.yml` as a workaround: ```yaml global: - 'force create mode = 0644' -...

Hey- I agree with you that a separate core module is the way to go. A pull request would be great for sure! I was also thinking of migrating to...

I ended up preferring Gradle over Maven for its much easier customizability and its nice Kotlin DSL. I also find it evolves much faster, which may or may not be...

Is this still a problem? What was the culprit?

@anuraaga That's a great point. What do you think, @moonchanyong ?