Trustin Lee comments

Results 271 comments of


                                            Trustin Lee

Provide a way to customize gRPC content logging

I'm just trying to assess the risk. What risk would it have?

More `HealthChecker` implementations

You can add more than one health checker when you build a HealthCheckService, then a load balancer or HealthCheckedEndpointGroup will notice when any of the HealthCheckers becomes unhealthy.

More `HealthChecker` implementations

Sure. Please tell us what kind of health checkers you'd like to implement first, though. :-)

TomcatService does not support AsyncServlet.

Yeah, I tried to get this work, but could not figure out how. Care to dive deeeeep?

Make annotated services reject the multipart requests that contain an uninjectable file upload

Sure. Why not? :smile:

xDS support in Armeria gRPC

We hope to get this feature ready around December 2023 or January 2024.

xDS support in Armeria gRPC

@Lincong Are you still interested in this issue? We're actively working on this issue and would like to gather the requirements (specific features?) as well as the environment (Istio?).

Change the behavior of `RequestContext.addAddtionalHeaders`

Thanks @alexc-db and @vkostyukov for your feedback. 🙇

Automatically create armeria's dependency when missing

`BuiltInDependencyInjector` could discover them via Java SPI. Java SPI also uses the default constructor for instantiating the provider, so we could simply define a tag interface and list the types...

Provide more ways to mark a thread as non-blocking

Other frameworks like Netty will benefit from resolving this issue as well, since Netty could mark their event loop thread classes as non-blocking out of the box. (but I'm not...