Richard Truong-Chau comments

Results 6 comments of


                                            Richard Truong-Chau

data_summary: Exception: Internal Error

> @truongc2 Is this related to #389? You could test by running with modin >=0.8.2 which was just released a month ago. You're right. It's related to #389. I'll integrate...

WIP: Fixed data_heatmap (seaborn backend) coloring for null values. Added type hints and argument types for function signature.

> Is there a way to have a unit test that verifies the fix? I'm not sure what the original bug was - was it just related to the colormap?...

Publication readiness

What does being publication ready entail? Is it just choosing a standard font, color, text size, line width, etc.?

data heatmap data issue

@haishiro Is the assumption that missing values are marked as white? So in this case, the plotly plot is correct and the seaborn plot is the incorrect version?

WIP: Added explicit import for pyLDAvis.gensim in topic_model widget.visualize_topic_summary()

> Any way to test this in unit tests? Would you suggest mocking the notebook environment?

Pump Sensor Example

Code looks good and EDA is detailed. Adding some requests for changes below: - Add markdown and provide a title - Put all module imports at the top of the...