awesome-data-science-models icon indicating copy to clipboard operation
awesome-data-science-models copied to clipboard

Pump Sensor Example

Open rhaswah opened this issue 5 years ago • 1 comments

rhaswah avatar Mar 03 '21 17:03 rhaswah

Code looks good and EDA is detailed. Adding some requests for changes below:

  • Add markdown and provide a title
  • Put all module imports at the top of the file
  • Check your spacings i.e. cell 19
  • Use head / tail to preview the dataframe
  • In the markdown before cell 14, you have an incomplete sentence
  • Remove commented code
  • Rerun the notebook so the the cells are in order. Expect to rearrange the code as some variables are defined out of order
  • Consolidate the preprocessing steps so most if not all transformations happen in the same or nearby cells
  • Add "EDA" to the filename
  • Create a folder "EDA" and move the notebook into it

truongc2 avatar Mar 03 '21 18:03 truongc2