Henric Persson
Henric Persson
Hi @aswara, and thanks for the PR! In order to get things like this merged, you'll need to provide a thorough description of the feature you're adding. Some things to...
While I think the work @TN1ck did here is good, I feel like this library isn't the right tool for the job. I would recommend looking into Intersection Observer for...
Thats a neat idea! I worry a little that it might interfere with the functionality however. Waypoints are by default a `` with no width and no height. Making it...
The schema was added by @jmeas, not me. :)
I think this would make sense -- I'd be happy to accept a PR adding support for this usecase. In the meantime, do you want to share what your wrapper...
Thanks! I think I'd prefer the `fireOnce` option. I don't see a clear use-case for the count so a boolean should do.
In your use-case, it wouldn't make sense to fire `onLeave`, right? In that case, we could just add that behavior to the documentation (README file).
Yep, that was how I interpreted the feature! If people come across the `fireOnce` property and need the `onLeave` as well, we can just change the behavior in a later...
Would you like to push that as a PR so that others can benefit? I'm thinking this could be an `onLoad` event where we pass in `currentPosition` (just like for...
@dzucconi I traced that log down to this test case: https://github.com/brigade/react-waypoint/blob/68d1948b26509941ec601057d1df989bb68366de/test/waypoint_test.jsx#L874 I've pushed a PR addressing the confusion around the error message here: https://github.com/brigade/react-waypoint/pull/255. You can safely ignore the error...