react-waypoint icon indicating copy to clipboard operation
react-waypoint copied to clipboard

When debug mode enabled, it could be great to display the "match zone"

Open kud opened this issue 8 years ago • 5 comments

… with a red line border or something like that. :)

kud avatar May 12 '17 16:05 kud

Thats a neat idea! I worry a little that it might interfere with the functionality however. Waypoints are by default a <span> with no width and no height. Making it have a width and/or a border/height might change the behavior.

Is this something you'd like to explore in a PR?

trotzig avatar May 12 '17 16:05 trotzig

What about box-shadow? or/and in position: absolute, or something like, not to interfere with the interface. :)

I'll check that if i've got time. But your schema on README was a nice idea, I understood better the way it works.

kud avatar May 12 '17 16:05 kud

We could add an outline to prevent any regressions in behavior.

Edit: box shadow could work, too!

jamesplease avatar May 12 '17 16:05 jamesplease

The schema was added by @jmeas, not me. :)

trotzig avatar May 12 '17 16:05 trotzig

Another idea – and this would be an ambitious project – is an interactive ‘schema,’ like what’s in the README. Imagine if the website had a GUI where you could adjust the props, and visualize the waypoints. Then, you could scroll and see some callbacks. There could be different common “scenarios” (i.e.; examples where it makes sense to use a waypoint as a line, or with children).

Although, maybe just more examples would serve the same purpose and require less engineering effort. I’m not too sure.

Either way, I’m all in favor of any idea that we think could help people get the hang of using this library! I know some of the “new” concepts (offsets, boundaries, children) have increased the learning curve of this library as a side effect of us making it more powerful.

jamesplease avatar Jul 17 '17 06:07 jamesplease