Henric Persson

Results 310 comments of Henric Persson

> It's could be nice if unspecified properties can be better visible in the warning. Ah, that's a good idea! I'll change the title of this issue to make it...

> It would be nice, if separate_groups used without order would enforce a capsulated order of groups. I'm not sure I understand this suggestion. How would we know what to...

Ah, I see what you mean now. Arbitrary groups with alphabetic ordering enforced within the groups. I don't think this is possible with the current implementation. I'm happy to accept...

Echoing what @sds informed me about when I ran into the same issue: > Because of the nature of the latest overcommit version, you needed to pull/rebase with `OVERCOMMIT_DISABLE=1`. So...

For this type of fine-control behavior I would probably look into using [IntersectionObserver](https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API).

If you inspect the waypoint div (using developer tools in the browser), is it in the viewport after having fired `onLeave`?

I wonder if the wrong `scrollableAncestor` is picked up? Can you check the `debug` output to make sure that this property is referencing the right element in the DOM?

Alright, I see nothing odd in that debug output. Can you describe your usecase a little more? You are tracking whether a header has left the top of the viewport,...

It looks like the waypoint is wrapping the header. Do you get different results if you avoid the wrapping? e.g. ```jsx I'm a header

This looks like a bug to me. Would you be willing to submit a PR fixing this? As a workaround, you can set the `scrollableAncestor` prop to `window`.