Henric Persson

Results 310 comments of Henric Persson

By the way, this is what I had in mind for the Storybook UI (in its simplest form): If you hit that button, we would show one or more screenshots...

I think the fix for this involves moving cursor restoration into the import-js plugin itself. The client will send the current position on import start, then import-js will calculate where...

@lencioni: Is this something you're still considering?

You mean ES5, right? The shipped npm module is already transpiled, but you're right that we need the polyfill and the x/y properties. We'd be very happy for a PR!

I think we should just switch to [`isFinite`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/isFinite). It doesn't check that the argument is a number, but it works across all browsers. And we know that we're always passing...

Thanks! I'm going to need someone at Brigade merge and release this change (I'm no longer part of the organization).

@SiriusZael, maybe you can take care of merging and releasing this?

Let's ping some folks to see if we can get this merged and released! @eleather, @z3usy - any chance we can get someone on the brigade web team to merge...

I'll let @janpaul123 chime in here, but I feel like that's a different case, best handled in your application.

Hi @wokayme, and thanks for the feature request! This would definitely make sense. My main concern is that we've made async comparisons the default, which means the comparison result will...