delayed-scroll-restoration-polyfill icon indicating copy to clipboard operation
delayed-scroll-restoration-polyfill copied to clipboard

Published 20 hours ago • verified publisher icon janpaul123

SSR compatibility

Open bradcgarner opened this issue 6 years ago • 5 comments

Only changed if statement on 1st line so that the polyfill is not attempted when server-side-rendering, but still triggers after the file renders in the browser. For compatibility with Next.js or other SSR technologies.

bradcgarner avatar Dec 09 '18 16:12 bradcgarner

Thanks! I'm going to need someone at Brigade merge and release this change (I'm no longer part of the organization).

trotzig avatar Dec 12 '18 09:12 trotzig

@SiriusZael, maybe you can take care of merging and releasing this?

trotzig avatar Dec 12 '18 09:12 trotzig

Hey, just checking to see if this PR will be merged. I'm hosting a local copy of the repo, since I can't use the node module with Next.js without this PR. Thanks!!

bradcgarner avatar Jan 08 '19 15:01 bradcgarner

Let's ping some folks to see if we can get this merged and released! @eleather, @z3usy - any chance we can get someone on the brigade web team to merge and release this?

trotzig avatar Jan 08 '19 20:01 trotzig

Thanks for merging! But just checking when this approved change for SSR will be published. I'm currently hosting a copy of this in each repo that uses it, since the published version won't work with SSR.

bradcgarner avatar Aug 01 '19 00:08 bradcgarner