Results 71 comments of Sergei Trofimovich

No, this PR (and disabled warnings) is all I needed to get it to build.

`kalilinux` has an example fix at https://gitlab.com/kalilinux/packages/truecrack/-/blob/kali/master/debian/patches/fix-multiple-declarations.patch

I noticed `.input` and `.keys` file are written using relatively small (~1k, ~3K) buffers when passing those to kernel. I wonder if penalty per write on your system is somehow...

Linux kernel did a bit of back-fo-the-napkin math for reasonable abbreviation for reasonable sizes of the repos in 2010: https://lkml.org/lkml/2010/10/28/287

Attaching the file: [build_152619227.txt](https://github.com/nix-community/nix-review-tools/files/7152826/build_152619227.txt)

Using `emacs` as an example bisected `patchelf` down to 42394e880bc5524122234fe2c2eaa043063ac581 `write out replace sections in original order`. It's gist st change of traversal from ```c++ for (auto & i :...

I tried `master` as well and it did not fix the issue for me. Tested as: ```diff --- a/pkgs/applications/editors/emacs/generic.nix +++ b/pkgs/applications/editors/emacs/generic.nix @@ -46,6 +46,7 @@ else "lucid") , withSystemd ?...

https://github.com/NixOS/nixpkgs/pull/221900 was merged into `staging-next` to fix `emacs`. You might need to revert the change locally to reproduce it on` staging-next`.

This commit fails for me (it's the one directly preceeding the `patchelf-0.15.0` pin): ``` $ nix run https://github.com/NixOS/nixpkgs/archive/403b148aa51073bc343febbbfd041ecd495dbe3e.tar.gz#emacs Segmentation fault (core dumped) ``` This should allow extracting exact binary: ```...

https://github.com/NixOS/nixpkgs/pull/276892 is another case where just following commit message attribute might be more desirable. It's a no-op change from rebuild standpoint but I still would prefer maintainers to review that...