ofborg does not use `$attr.meta.maintainers` when `$attr` is in the commit message
Example PR: https://github.com/NixOS/nixpkgs/pull/276696
There:
nix_2_3(ornixVersions.nix_2_3) was explicitly specified in commit message.nix replagrees$attr.meta.maintainersdoes exist:nix-repl> nixVersions.nix_2_3.meta.maintainers=>[ { ... } { ... } ]- the PR does cause
nixVersions.nix_2_3rebuild
@lilyinstarlight says it's a side-effect of nixVersions.nix_2_3 defining most of it's relevant attributes in a file different from default.nix (common.nix). I suspect nix is not the only one doing it.
Proposal: extend ofborg to also handle direct $attr.meta.maintainers expand attributes right from the commit message (and possibly filter only on packages affected by the rebuild if reasonably feasible). I suspect that is what it does today to fetch tests and build the attribute.
https://github.com/NixOS/nixpkgs/pull/276892 is another case where just following commit message attribute might be more desirable.
It's a no-op change from rebuild standpoint but I still would prefer maintainers to review that kind of change.