Thomas Roch comments

Results 79 comments of


                                            Thomas Roch

Examples are not accessible

Having some issues with the domain, will fix ASAP

leave current step only when next one is ready

Hi @juliender, thanks for the PR. I don't feel like it is a change I can push to all users, so I would make it optional. Can you add a...

step is passed to the onStepChange method as an argument

Thanks for your contribution. This seems perfectly reasonable to add this feature and I'll merge it and release it as soon as I'm finished with what I'm doing (working on...

step is passed to the onStepChange method as an argument

I'm hoping to have an update soon, I've been unable to free some time due to work and family commitments.

step is passed to the onStepChange method as an argument

The method will pass the active step index, is that fine? Or would prefer it to pass the step object instead?

step is passed to the onStepChange method as an argument

Nope steps don't include an index as its own property. I think I need to first change how indexing works (they are not zero based, that was a stupid decision)...

step is passed to the onStepChange method as an argument

OK. I might merge it at some point. I'll rework indexing to be zero based in a near future (breaking change, will bump version to 2.0.0).

Backdrop remains after modal is closed

Thanks for reporting, I'll look into it

Hooks?

v7 of router5 is out, it also has hooks, if you want to have a look.

Better document using ordered-read-stream to handle multiple streams being returned

I agree with returning an array not being a good solution. Maybe adding merge-stream or merge2 as a gulp dependency and making `gulp.merge` available?