angular-multi-step-form icon indicating copy to clipboard operation
angular-multi-step-form copied to clipboard

step is passed to the onStepChange method as an argument

Open rdzidziguri opened this issue 8 years ago • 10 comments

rdzidziguri avatar Jun 22 '16 17:06 rdzidziguri

Thanks for your contribution. This seems perfectly reasonable to add this feature and I'll merge it and release it as soon as I'm finished with what I'm doing (working on another new feature and updating dependencies + build). Should be done by the end of the week.

troch avatar Jun 22 '16 20:06 troch

The only question i have regarding this is will step include index or current page? the problem i cam up with this solution was to know which is active step in callback method.

U are welcome i am always glad to contribute to the good OpenSource projects like this.

rdzidziguri avatar Jun 23 '16 21:06 rdzidziguri

Do we have any update on this?

rdzidziguri avatar Jun 30 '16 21:06 rdzidziguri

Do we have any status update on this or when we are going to receive new release?

rdzidziguri avatar Jul 12 '16 18:07 rdzidziguri

I'm hoping to have an update soon, I've been unable to free some time due to work and family commitments.

troch avatar Jul 20 '16 12:07 troch

The method will pass the active step index, is that fine? Or would prefer it to pass the step object instead?

troch avatar Jul 24 '16 22:07 troch

does step include index as its own property? if yest we could pass that object otherwise i do not see reason for this so index would be fine, but again if step instance will include index itself this is best i think/

rdzidziguri avatar Jul 30 '16 20:07 rdzidziguri

Nope steps don't include an index as its own property. I think I need to first change how indexing works (they are not zero based, that was a stupid decision) before exposing indexes.

troch avatar Aug 10 '16 08:08 troch

Actually after adding controller for step container i thin it is extra to re implement indexing anyone could easily get active step index and using base methods get step info.

rdzidziguri avatar Aug 11 '16 10:08 rdzidziguri

OK. I might merge it at some point. I'll rework indexing to be zero based in a near future (breaking change, will bump version to 2.0.0).

troch avatar Aug 11 '16 14:08 troch