Todd Martin

Results 44 comments of Todd Martin
trafficstars

> I think [this](https://contributing-internal.bitwarden.com/external/server/ef/#generating-ef-migrations) Is what's missing - generating the EF migrations. I think it's definitely unclear that this is required, as it's not linked at all in the actual...

For internal tracking: https://bitwarden.atlassian.net/browse/PM-6395

> I'd wait one more release cut to give the clients time to propagate. @withinfocus any concern with our 3-release backward compatibility on clients here? Should we wait 3 client...

@MGibson1 it looks like the MacOS desktop builds are failing with an error around `distutils`: `No module named 'distutils'`

Addressed `message.json` merge conflicts and re-requested review.

Note that the scope of this has been reduced to just the `login-decryption-options` component. I originally included the `login-via-auth-request` component as well, even though it wasn't explicitly in the ticket,...

@coroiu do you recall why the `Assert...` command handles validation issues by throwing a `BadRequestException`, whereas the `Create...` command returns `false`? Is it because we are already returning additional data...

I had to make the `CreateWebAuthnLoginCredentialCommand` `public` in order for the tests to pass, given that I had a dependency on `ILogger`. I'm not quite sure why, which doesn't give...

This is excellent! Thank you for all the time you've spent getting this put together. I had a question and a suggestion, which might help guide future changes to the...

Hello! This has been identified internally and is currently fixed in our `main` branch (https://github.com/bitwarden/clients/pull/9579). It will be included in our next release.