[PM 4973] migrate change kdf component

[vinith-kovan]

trafficstars

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Migrate the Change kdf component to use the component library.

Code changes

change-kdf.component.html: Updated the form, inputs, and select options to use the equivalent components from the Component Library. change-kdf.component.ts: Added from group to capture the form values

Screenshots

Before Migration:

After Migration:

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 4.16667% with 46 lines in your changes missing coverage. Please review.

Project coverage is 28.84%. Comparing base (dfd4479) to head (7471a40).

Files	Patch %	Lines
...ttings/security/change-kdf/change-kdf.component.ts	4.16%	46 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8485      +/-   ##
==========================================
- Coverage   28.86%   28.84%   -0.02%     
==========================================
  Files        2509     2509              
  Lines       73266    73308      +42     
  Branches    13679    13685       +6     
==========================================
+ Hits        21147    21149       +2     
- Misses      50510    50549      +39     
- Partials     1609     1610       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[github-actions[bot]]

Checkmarx One – Scan Summary & Details – 6c3612b2-2333-4912-a979-c31fb4b0909d

No New Or Fixed Issues Found

[trmartin4]

Adding @JaredSnider-Bitwarden as reviewer as he was already assigned to the confirmation PR: https://github.com/bitwarden/clients/pull/8489. I'm not sure why Github didn't auto-assign here.

[danielleflinn]

@vinith-kovan From a design perspective we'd like to make a few tweaks to the UI while we are in this view. Can you update the PR to the following?

• Add this instructional text:

Higher KDF iterations can help protect your master password from being brute forced by an attacker.


For older devices, setting your KDF too high may lead to performance issues. Increase the value in increments of 100,000 and test your devices.

• When Argon2 is selected, update the page's instructional text to use "small increments" instead of "increments of 100,000"
• Remove the 2nd callout
• Remove existing hint text and addbit-hinttext below the KDF iteration field if "PBKDF2 SHA-256" is selected as the algorithm

[jlf0dev]

@vinith-kovan is this ready for review again? Just noticed you requested it ^

[vinith-kovan]

@jlf0dev Sorry mistakenly clicked re-review, anyway, it is getting ready in sometime and let you know.

[vinith-kovan]

@jlf0dev Now It's ready for review.

[jlf0dev]

@vinith-kovan Can we please also have an updated screenshot with the new UI changes? Thanks!

[vinith-kovan]

@jlf0dev https://github.com/bitwarden/clients/pull/8485#discussion_r1609966522

I think the above issue has already been clarified with @willmartian, if we remove the min and max in the template that will allow the users to enter any values even though we configured the Validators in ts file because even number input is considered as string, so we need to add min and max.

[trmartin4]

Addressed message.json merge conflicts and re-requested review.