[PM-5551] Removing Autofill v2 and AutofillOverlay Feature Flags

[cagonzalezcs]

trafficstars

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This ticket removes the autofill v2 and autofill overlay feature flags to have these features be set by default. These changes also ensure that self-hosted Bitwarden servers have access to these features.

Code changes

• src/Core/Constants.cs: Removing the AutofillV2 and AutofillOverlay feature flags

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.19%. Comparing base (ffdf14c) to head (c26e2ce).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3692   +/-   ##
=======================================
  Coverage   36.19%   36.19%           
=======================================
  Files        1158     1158           
  Lines       56108    56108           
  Branches     5385     5385           
=======================================
  Hits        20307    20307           
- Misses      34855    34856    +1     
+ Partials      946      945    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – 5ecb5e39-ed49-4c68-b83d-27cd405b28af

No New Or Fixed Issues Found

[github-actions[bot]]

LaunchDarkly flag references

:x: 2 flags removed

Name	Key	Aliases found	Info
Autofill Overlay	autofill-overlay		:white_check_mark: all references removed
Autofill V2	autofill-v2		:white_check_mark: all references removed

[cagonzalezcs]

Note to reviewers: These feature flags are obsolete now, as their usage within the extension has been removed entirely as of the v2024.2.0 release. This PR just cleans up those flags entirely.

[withinfocus]

How long has this been out of the client code? We have to be sensitive to adoption, because if this releases server-side then a not-updated client will default to not getting the functionality. If that's an acceptable risk and timeline then we can merge.

[cagonzalezcs]

@withinfocus

The client side removal of the feature flag will be introduced with the upcoming release, v2024.2.0. The removal of this flag is present here - https://github.com/bitwarden/clients/pull/7642

I can definitely hold off on merging this work in after we introduce that version of the extension, if that makes sense to do. However, since rc was cut earlier this week, the changes in this PR should be releasing approximately 2 weeks after we release the client side changes.

[withinfocus]

I'd wait one more release cut to give the clients time to propagate.

[trmartin4]

I'd wait one more release cut to give the clients time to propagate.

@withinfocus any concern with our 3-release backward compatibility on clients here? Should we wait 3 client releases before we remove the flag altogether? Or is it OK to go sooner since this is only in the browser and it's difficult (impossible?) to be running an old version in normal usage.

[withinfocus]

I think it's fine to go sooner, and the removal of flags isn't bound to the same compatibility rules as a feature itself e.g. a breaking change.

[cagonzalezcs]

@withinfocus @trmartin4

Are we in a good position to merge this change in? Just looking to clear the Jira ticket for this task.

[withinfocus]

Especially since an RC just cut, yes I am in support.

[cagonzalezcs]

Fantastic thank you Matt! As soon as an approval is provided, I'll make sure this gets merged in.