Tom Rhys Jones

icon company Expensify

Results 339 comments of Tom Rhys Jones
trafficstars

Distance offline - Can't delete red dot Error on the request preview in the expense report

Ah yeah, totally. If we're committed to doing that, then let's go for it. Minimally, it shouldn't get stuck like it is now though in the current imp.

Distance offline - Can't delete red dot Error on the request preview in the expense report

Yeah, I think ideally we would handle this in a way that still creates a partial transaction that the member can edit the waypoints to fix it - @neil-marcellini references...

[HOLD for payment 2024-04-15] [Violations][$500] Scan - Category row shows violation briefly after the scan request is created

Hm, why wouldn't we show the category violation right away if categories are required on the workspace? 🤔 CC: @JmillsExpensify @cead22

[HOLD for payment 2024-04-15] [Violations][$500] Scan - Category row shows violation briefly after the scan request is created

Yeah, I agree with it insofar as I don't know why it's disappearing. This is violations related though, so one for #wave-control. :)

[HOLD for payment 2024-04-15] [Violations][$500] Scan - Category row shows violation briefly after the scan request is created

>I think I also agree with @trjExpensify that the violation should be shown as long as it's required by the workspace, regardless of whether it's scanning or not. @cead22 Do...

[$500] `openApp` and `reconnectApp` consistently failing every time sign into the app with error

Is something taking this on internally? Is it part of the fire clean-up or something?

[$250] Chat - Compose box is hidden when editing multiple line break message

@rojiphil any feedback on [this](https://github.com/Expensify/App/issues/40767#issuecomment-2091230417)?

[$250] [Guided Setup] Redirect where user was when they try to deeplink to the onboarding flow after completion

>I think we discussed before if we should even allow the deeplink once user completed the flow @trjExpensify I don't recall that, but it kinda' makes sense. If they've completed...

[$250] [Guided Setup] Redirect where user was when they try to deeplink to the onboarding flow after completion

Looks like we're ready for a re-review here, @c3024. Thanks!

[$500] Chat - Attachment page keeps on loading infinitely.

I agree the infinite loading spinner isn't great, but I think this is a [dupe](https://github.com/Expensify/App/issues/13826) and been around for a long time. The real solution for this is better support...