App icon indicating copy to clipboard operation
App copied to clipboard

[$500] `openApp` and `reconnectApp` consistently failing every time sign into the app with error

Open m-natarajan opened this issue 1 year ago • 23 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): [email protected] Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712076134934759

Action Performed:

  1. Sign in to app

Expected Result:

Should be no error

Actual Result:

openApp and reconnectApp shows error

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [ ] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (7)

image (6)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01db64f0c98a4baf4f
  • Upwork Job ID: 1775338512686096384
  • Last Price Increase: 2024-04-03

m-natarajan avatar Apr 02 '24 22:04 m-natarajan

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot[bot] avatar Apr 02 '24 22:04 melvin-bot[bot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

MelvinBot avatar Apr 02 '24 22:04 MelvinBot

Had a quick look at this with Jason 1:1. I can't manage to reproduce this on my account. Those API calls (openApp and reconnectApp) do not error on my account. And I'm not comfortable supportaling into another staff members account to check if they error there.

I think this needs someone from engineering to triage and diagnose further.

nathanmetcalf avatar Apr 02 '24 23:04 nathanmetcalf

Job added to Upwork: https://www.upwork.com/jobs/~01db64f0c98a4baf4f

melvin-bot[bot] avatar Apr 03 '24 01:04 melvin-bot[bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @dukenv0307 (Internal)

melvin-bot[bot] avatar Apr 03 '24 01:04 melvin-bot[bot]

@dukenv0307 (since you're assigned) just curious: are you able to repro this?

jliexpensify avatar Apr 03 '24 01:04 jliexpensify

@jliexpensify There's no error on my side. Here's the evidence

https://github.com/Expensify/App/assets/129500732/a2592083-453e-47d7-971b-a96bf3e30fcc

dukenv0307 avatar Apr 03 '24 04:04 dukenv0307

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

melvin-bot[bot] avatar Apr 03 '24 22:04 melvin-bot[bot]

@dukenv0307 we're going to move forward with attempting to diagnose and fix this issue. Hoping a Contributor can repro and has a solution!

jliexpensify avatar Apr 03 '24 22:04 jliexpensify

Almost sure that this is internal, since the error is in the API command

iwiznia avatar Apr 03 '24 22:04 iwiznia

Current assignee @dukenv0307 is eligible for the Internal assigner, not assigning anyone new.

melvin-bot[bot] avatar Apr 03 '24 22:04 melvin-bot[bot]

Thanks @iwiznia!

jliexpensify avatar Apr 03 '24 22:04 jliexpensify

@puneetlath can you check if you get the same error in ReconnectApp but not on the call right after loading the app like the one above, instead, disconnect from wifi and recconect to it and check the response there? If it works (I assume it will) then the only problem is in OpenApp (which is called by ReconnectApp when we have no updateID, see https://expensify.slack.com/archives/C06SCNUBB28/p1712181414857909)

iwiznia avatar Apr 03 '24 22:04 iwiznia

It seems you are right @iwiznia

Screenshot 2024-04-04 at 3 52 55 PM Screenshot 2024-04-04 at 3 53 02 PM

puneetlath avatar Apr 04 '24 19:04 puneetlath

So if I'm understanding correctly, it seems like this issue will be resolved with Ioni's PR right?

jliexpensify avatar Apr 04 '24 22:04 jliexpensify

Just the reconnect part

iwiznia avatar Apr 04 '24 23:04 iwiznia

Yeah, so we still need to fix the OpenApp issue that I'm experiencing.

puneetlath avatar Apr 05 '24 16:04 puneetlath

Just wondering: this openApp error is a general sign in issue, but doesn't fit into any Waves - but it could fit under the setup/support part of #collect. Would it be appropriate to add there?

jliexpensify avatar Apr 07 '24 22:04 jliexpensify

I feel like #wave-collect makes sense.

puneetlath avatar Apr 09 '24 12:04 puneetlath

@jliexpensify, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Apr 11 '24 18:04 melvin-bot[bot]

Is something taking this on internally? Is it part of the fire clean-up or something?

trjExpensify avatar Apr 11 '24 19:04 trjExpensify

@trjExpensify - @hayata-suenaga has confirmed that this isn't fire-related. Would you consider this a Hot Pick? Otherwise, if it's appropriate (since it kind of fits, but also doesn't), I can also post in the #wave-collect channel to see if someone can take it.

jliexpensify avatar Apr 13 '24 01:04 jliexpensify

I think you can post it in wave-collect 😄

hayata-suenaga avatar Apr 15 '24 23:04 hayata-suenaga

Done!

jliexpensify avatar Apr 16 '24 01:04 jliexpensify

@jliexpensify @dukenv0307 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] avatar Apr 16 '24 18:04 melvin-bot[bot]

I'll take on looking into this. Since I'm the main person affected.

puneetlath avatar Apr 16 '24 18:04 puneetlath

@puneetlath, @jliexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] avatar Apr 19 '24 18:04 melvin-bot[bot]

I am facing this, logs here. Could it be related to mostRecentReportActionLastModified being malformed?

pecanoro avatar Apr 22 '24 13:04 pecanoro

@marcaaron Any ideas why we are generating the oldest like this? It's not a valid format for the back-end.

Malformed REQUEST: 'mostRecentReportActionLastModified' = '1970-01-01T00:00:00.000Z', ignoring (should match '\d{4}-\d{2}-\d{2}( \d{2}:\d{2}:\d{2}(\.\d{3})?)?').

pecanoro avatar Apr 22 '24 13:04 pecanoro