[$250] [Guided Setup] Redirect where user was when they try to deeplink to the onboarding flow after completion

[kbecciv]

trafficstars

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.65-0 Reproducible in staging?: y Reproducible in production?: n Issue reported by: Applause - Internal Team Issue found when executing PR: https://github.com/Expensify/App/pull/40667

Action Performed:

1. Open expensify staging app
2. Open any chat
3. Send this url https://staging.new.expensify.com/onboarding
4. Tap on the sent URL to start the onboarding flow
5. Tap on any one of the purpose options more than one time

Expected Result:

When the user already completed the guided setup flow, we should make sure we re-navigate them to the main page after they attempt to deeplink to the flow

Actual Result:

Users can go through the onboarding flow as many times as they want

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/5538576a-840c-4367-8c8d-ee14a5f55f0b

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5d3f767fe2611e7
• Upwork Job ID: 1783996337884426240
• Last Price Increase: 2024-04-26

[melvin-bot[bot]]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[mountiny]

Taking over

[mountiny]

I think we discussed before if we should even allow the deeplink once user completed the flow @trjExpensify

Nevertheless this is not a blocker as its minor ui bug

[trjExpensify]

I think we discussed before if we should even allow the deeplink once user completed the flow @trjExpensify

I don't recall that, but it kinda' makes sense. If they've completed onboarding and in-product natively we don't show it again -- then getting there via deeplink shouldn't work either.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01a5d3f767fe2611e7

[mountiny]

Updated the instructions

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[skyweb331]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Do not allow user repeat the onboarding steps when already completed the onboarding steps

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

Backend sends {nvp_onboarding: {hasCompletedGuidedSetupFlow: true} and using this value, Two solutions.

1. Remove the Onboarding Route in AuthScreens.tsx, thus user will remain on the current report if he/she clicks the onboarding link, or will go to the last report if he/she comes from outside via direct link
2. On OnboardingModalNavigator, redirects the user to Concierge page, thus user will be redirected to his/her Concierge page if he/she clicks the link.

What alternative solutions did you explore? (Optional)

n/a

[c3024]

Checking. Will update in a while.

[c3024]

Expected result from the post is

When the user already completed the guided setup flow, we should make sure we re-navigate them to the main page after they attempt to deeplink to the flow

So, option 2 of the solution suggested in the proposal here by @skyweb331 looks good to me.

🎀 👀 🎀 C+ Reviewed

[melvin-bot[bot]]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[skyweb331]

I am testing the code on Android and IOS.

[melvin-bot[bot]]

@youssef-lr, @mountiny, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[skyweb331]

@c3024 I failed android installation, so I could not submit the PR. I tested my code on all environments except Android. I tried android on both Mac and Linux, but stopped at the last step.

[c3024]

Bump @youssef-lr. This is waiting for assignment. Thanks.

[melvin-bot[bot]]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @skyweb331 You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

I am going to ai am back from ooo (thats why Youssef got assigned) so taking this over again, thank you!

[mountiny]

@skyweb331 can you raise the pr please even without the android videos, add the rest please

[skyweb331]

@mountiny OK. I will upload my PR soon.

[skyweb331]

@mountiny PR is submitted.

[trjExpensify]

Looks like we're ready for a re-review here, @c3024. Thanks!

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @skyweb331, @mountiny, @c3024 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.79-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/42087

If no regressions arise, payment will be issued on 2024-06-13. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @skyweb331 requires payment (Needs manual offer from BZ)
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot[bot]]

Issue is ready for payment but no BZ is assigned. @joekaufmanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[joekaufmanexpensify]

We need to pay:

• @skyweb331 $250 for PR via Upwork.
• @c3024 $250 for C+ via Upwork.

[joekaufmanexpensify]

@skyweb331 please share your upwork profile here so we can hire you