Trivikram Kamat

Results 146 comments of Trivikram Kamat

> The hardest part here is to tell Vitest to stop running all other workers from within the worker without breaking Tinypool. Can we use [SharedArrayBuffer](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer) to store `numberOfFailedTests` so...

> but we also support `child_process`. The `numberOfFailedTests` can be tracked by sending messages between parent and child using [subprocess.send](https://nodejs.org/api/child_process.html#subprocesssendmessage-sendhandle-options-callback).

It looks like the messages can be exchanged between worker threads or child processes using `RuntimeRPC` interfaced passed in `createBirpc` * Interface https://github.com/vitest-dev/vitest/blob/895103ab0c75b86ed57f84424937eb9003a65c6e/packages/vitest/src/types/rpc.ts#L9 * child.ts https://github.com/vitest-dev/vitest/blob/895103ab0c75b86ed57f84424937eb9003a65c6e/packages/vitest/src/node/pools/child.ts#L19 * https://github.com/vitest-dev/vitest/blob/895103ab0c75b86ed57f84424937eb9003a65c6e/packages/vitest/src/node/pools/threads.ts#L23

After diving deep into the source code, I think the `numberOfFailedTests` can be tracked in Vitest core. High level suggestion: * The variable can be similar to `restartsCount` (say `failedTestsCount`)...

cc recent committers @Lou1415926 @paragbhingre for review

AWS SDK for JavaScript v2 will enter maintenance mode on September 8, 2024 and reach end-of-support on September 8, 2025. For more information, check blog post at https://a.co/cUPnyil

Looks like this issue can be closed, as the issue is not reproducible. #### node v18.16.0 ```console $ npm test .... FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed...

cc active contributors @danpat @mjjbell

@gornostal Our endpoint resolution has changed since this issue was reported in May'21. Is this issue still reproducible for you?

The HttpRequest is created in serializer. I logged the contents in `buildHttpRpcRequest` before HttpRequest is created, for testing listTables ```js // node_modules/@aws-sdk/client-dynamodb/dist-cjs/protocols/Aws_json1_0.js const buildHttpRpcRequest = async (context, headers, path, resolvedHostname,...