Trivikram Kamat

Results 146 comments of Trivikram Kamat

Revisiting during review meeting. The action item would be to check if endpoint which contains localhost is overridden in any middleware.

On quick revisit during review meeting for issues with `p1` labels, we noticed that this issue is likely in Node.js. Search results https://github.com/search?q=repo%3Anodejs%2Fnode+EPROTO&type=issues We need to find out whether the...

Revisiting this request to make corepack stable, as both yarn and pnpm recommend their users to use corepack: * Yarn 4.0 release notes https://yarnpkg.com/blog/release/4.0#installing-yarn * Pnpm installation https://pnpm.io/installation#using-corepack Some downstream...

Since yarn 4.0 stable is released in https://github.com/yarnpkg/berry/releases/tag/%40yarnpkg%2Fcli%2F4.0.0, this issue can be closed.

> PR welcome. Add `pr welcome` label, just like it's added in other issues? This post can be marked hidden as outdated once the label is added.

Is there any specific place folks can look at to introduce `--bail` option? For example, here is a function which marks failure for a task in a runner: https://github.com/vitest-dev/vitest/blob/895103ab0c75b86ed57f84424937eb9003a65c6e/packages/runner/src/run.ts#L198-L204

I think vitest runner needs to check value of suite.result.state after it's run, and break the for loop with failure if `bail` option is set. i.e. after line 327 in...

> I think vitest runner needs to check value of suite.result.state after it's run, and break the for loop with failure if `bail` option is set. Feel free to take...

With the above proposed solution, the checks will have to be added at multiple levels. For example, when the child suite is run concurrently https://github.com/vitest-dev/vitest/blob/895103ab0c75b86ed57f84424937eb9003a65c6e/packages/runner/src/run.ts#L253 Or the child suite is...

I think the check needs to be done in `runTest` function: * Track number of failed tests in a global variable (say `numberOfFailedTests`), if `bail` option is set. * Increment...