José Peso

Results 17 issues of José Peso

#### Summary Added ts-prune tool to dev dependencies in order to have a tool to report unused exported functions, var or constants. Usage: - In webapp folder: `npm run report-unused-exports`...

2: Dev Review

#### Summary Limit incoming requests to be 5MB large. Requests larger than that will fail. mattermost-server limit request with more size than max_file_size, playbooks plugin adds a lower limit: 5MB....

2: Dev Review

#### Summary Migrate all material design icons that exist in compass to compass icons. The SVG version of the icons has been used for most of the cases. The icons...

2: Dev Review

#### Summary Migrate font-awesome to compass icons: If merged after https://github.com/mattermost/mattermost-plugin-playbooks/pull/1460, currentColor prop can be removed. ``` src/components/backstage/playbook_edit/automation/auto_assign_owner.tsx:137: className='fa fa-times-circle' src/components/widgets/show_more.tsx:103: &.fa-angle-up { src/components/widgets/show_more.tsx:196: let showIcon = 'fa fa-angle-up'; src/components/widgets/show_more.tsx:199:...

2: Dev Review

#### Summary Cleanup after new RDP release: - removed ignored old e2e spec - moved timeline and retro to from playbook_run_backstage to playbook_run - header button done internally, fixed a...

2: Dev Review
Do Not Merge

Given the following resources: - Run (Public or Private) "R1" linked to a private Channel "C1" - A user "U1" who is a participant of "R1" and member of "C1"...

The current permissions still rely on channel members. They need to be migrated to run participants. ```go func (p *PermissionsService) RunManageProperties(userID, runID string) error { func (p *PermissionsService) RunView(userID, runID...

## Summary Taskinbox rescued from the last hackathon: - RHS is handled as it was done (before RDP) - feature behind playbooks experimental features - added e2e tests - added...

1: UX Review
2: Dev Review

## Summary Add actions to playbook and run to: - create a channel member when a new participant joins the run - remove a channel member when a existent participant...

1: UX Review
2: Dev Review

actions that should be reflected as timeline events: - addParticipants - removeParticipants