José Peso

Results 20 comments of José Peso

Hi, I would want to help with this one. Is it still a desired enhancement? is anyone already working on it?

Participate button has been already migrated as part of https://github.com/mattermost/mattermost-plugin-playbooks/issues/1402

> the table `IR_ViewedChannel` is missing in migration; was it intentional? not intentional, I added it and will be pushed soon. Nice catch @gbochora

Feedback addressed: @gbochora - added missing field migration to ir_incident - added missing table migration - fixed typo at ir_channelaction @lieut-data - created placeholder MySQL migrations to be more explicit...

Regarding point 2 (added themselves), I've [added events](https://github.com/mattermost/mattermost-plugin-playbooks/pull/1484/files) _playbookrun_participate_ and _playbookrun_leave_ which carry information about where the action has been done (playbooks-lhs, run_details, channels-rhs) As soon as RunDetails-Participants flow moves...

There's a regression in headerbutton, will fix it before asking review

@crspeller I changed the addRunParticipant to support multiple users in one shot.

> @trilopin Should it be symmetric then with removeRunParticipant also taking multiple users? UI interaction does not justify it, but we can create a mutation that accepts multiple removals too...

@abhijit-singh is the illustration available as svg file?

edge case that can be treated as independent