Tim Flynn
Tim Flynn
This test takes 2s to run on my desktop in a release build - on CI, especially with GCC sanitizers, it's consistently timing out. Disabled in #2656 CC @AtkinsSJ
Our current implementation is admittedly naive: https://github.com/LadybirdBrowser/ladybird/blob/93712b24bf298a61d3a614ce57574739015776c2/Libraries/LibCrypto/BigFraction/BigFraction.cpp#L137-L141 We use `BigFraction` in a couple places in our Temporal implementation, and this implementation is the last thing preventing us from passing 100%...
From the documentation of __lsan_do_leak_check: By calling this function early during process shutdown, you can instruct LSan to ignore shutdown-only leaks which happen later on. We currently have tens of...
The following URL: ``` https://lens.google.com/search?ep=gsbubb&hl=en&re=df&p=AbrfA8qtKaAznp-khYGGomI1i0sPFsEYkHYql-hBMlplgv3z98770wjlDsuTpGi1iwN8AGHAxwQmpcyMlHr0nWByzOPpll6G428cxYOBzgeJNCsnR7JDNP7RUzBXh6i4OGxT7HXQaaD7XhikzGUQusovihbjmf43G70LQOMm0ljt-Qwek4CkDUNE92v9aTtYaivtbEmt2PLW9ro7#lns=W251bGwsbnVsbCxudWxsLG51bGwsbnVsbCxudWxsLG51bGwsIkVrY0tKRE5sT1RRMU9EZG1MVFkwWmpJdE5EZzBZUzA1WlRNekxURmxaamxtWkRnM01EYzROQklmYzNsbU9XRlhlbk5OYlVGYVVVVjFlRFl4WHpJd1dFTmpUMWs0WkU5U2F3PT0iLG51bGwsbnVsbCxudWxsLG51bGwsbnVsbCxudWxsLG51bGwsWyI0Nzc0OTIwNC0wMjVhLTRlNjktYjkzOC1iOGY5MDQzNDhkNTciXV0= ``` Results in this crash on my Linux desktop: ``` VERIFICATION FAILED: surface at ladybird/Libraries/LibGfx/PaintingSurface.cpp:44 ladybird/Build/release/lib/liblagom-ak.so.0(ak_trap+0x35) [0x7b842e676c55] ladybird/Build/release/lib/liblagom-ak.so.0(+0x2af7f) [0x7b842e676f7f] ladybird/Build/release/lib/liblagom-gfx.so.0(+0xc42ce) [0x7b842e95b2ce] ladybird/Build/release/lib/liblagom-web.so.0 Web::HTML::CanvasRenderingContext2D::allocate_painting_surface_if_needed() 0xc5) [0x7b842fc19955]...
These were enabled recently in f1bbba2ba54913876830c1de2a293d6faee20535, but are frequently timing out on macOS. For example, see: Tests/LibWeb/Text/input/wpt-import/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-object-auto.html https://github.com/LadybirdBrowser/ladybird/actions/runs/12183133570/job/33983809382 Tests/LibWeb/Text/input/wpt-import/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-object-fixed.html https://github.com/LadybirdBrowser/ladybird/actions/runs/12183326749/job/33984479306 Tests/LibWeb/Text/input/wpt-import/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-fixed.html https://github.com/LadybirdBrowser/ladybird/actions/runs/12178592927/job/33968926325 These test were re-disabled in #2793.
This eliminates the use of `ResourceLoader` in `HTMLObjectElement`. The spec steps around fetching have been slightly updated since we've last looked at this, so those are updated here. Ref #2634
As measured on my desktop: ``` Text/input/wpt-import/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-object-fixed.html: 16791ms Text/input/wpt-import/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-percentage.html: 15222ms Text/input/wpt-import/html/rendering/pixel-length-attributes.html: 14812ms Text/input/wpt-import/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-object-percentage.html: 14582ms Text/input/wpt-import/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-fixed.html: 14577ms Text/input/wpt-import/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-auto.html: 13910ms Text/input/wpt-import/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-object-auto.html: 12893ms ``` The times of course get much worse in CI,...
We set the page's focused navigable upon mouse-down events from the UI. However, we neglected to ever clear that focused navigable upon events such as subsequent page navigations. This left...
This test just merged today in 056205aa76437eb797f74ce01305d3fd473e0a58 and has been seen failing quite a bit in CI. For example: https://github.com/LadybirdBrowser/ladybird/actions/runs/13681819369/job/38255830329 Attached are the artifacts from the failed test. Test was...