Tim Flynn

Results 131 issues of Tim Flynn

I was recently writing a test that involved iframes and came across this little annoyance. We currently have a handful of iframe tests whose sources are in the "input" directory....

👀 pr-needs-review

It seems we were errantly mixing seconds and milliseconds in this transient activation timeout. Increase it to 5 seconds, and be explicit about its type - DOMHighResTimeStamp is by definition...

👀 pr-needs-review

Instead of using C-arrays, and manually counting their lengths, use AK::Array. And pass these arrays around as spans, instead of as pointer-and-length pairs.

👀 pr-needs-review

This creates a shadow tree for the default UA interface, and finishes the plumbing for using chrome-specific file pickers: https://github.com/SerenityOS/serenity/assets/5600524/8be95db4-a78a-4794-9281-d2e5d350a3b7 Which also lets us open files on https://vscode.dev/: https://github.com/SerenityOS/serenity/assets/5600524/de854c7c-7712-490f-b352-90a255c8232d

👀 pr-needs-review

These changed to libexec in ea59bfaae7d3a307e0ba371518e7f36a33ae407d.

👀 pr-needs-review

With the LibJS JIT removed, let's not expose pointers to internal members.

👀 pr-needs-review

Just seeing where the lagom linux CI is losing so much disk space.

We're still hitting low disk space issues after #23404. Let's reduce disk usage even further.

👀 pr-needs-review

``` VERIFICATION FAILED: denominator != 0 at LibWeb/PixelUnits.h:306 ak_verification_failed +0x58 (Assertions.cpp:108 => Assertions.cpp:101) Web::Painting::PaintableBox::scroll_thumb_rect(Web::Painting::PaintableBox::ScrollDirection) const +0x23b (PixelUnits.h:306 => PixelUnits.h:385 => PaintableBox.cpp:280) Web::Painting::PaintableBox::paint(Web::PaintContext&, Web::Painting::PaintPhase) const [clone .part.0] +0xd7 (PaintableBox.cpp:351) Web::Painting::PaintableWithLines::paint(Web::PaintContext&, Web::Painting::PaintPhase)...

regression
has-repro