Mark Chappell

Thanks for your PR. Tests will currently fail due to missing permissions in CI. A matching PR on https://github.com/mattclay/aws-terminator/tree/master/aws/policy will also be needed.

Hi @dgiffordaudio, Not at this time. The bulk of modules in this collection are written and maintained by community members, rather than folks paid to work on Ansible. As such,...

Relevant excerpt from the Amazon Docs: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ses.html#SES.Client.set_identity_notification_topic > SnsTopic (string) -- The Amazon Resource Name (ARN) of the Amazon SNS topic. If the parameter is omitted from the request or...

The better option would be to add an optional "wait" parameter to the module so that it waits for the attachment to finish before returning.

Couple of quick comments: - It would be better if mq_broker could create/delete a broker. This would then support creating the broker as part of the integration tests so they...

@jillr wrote an initial guide: https://www.ansible.com/blog/getting-started-with-aws-ansible-module-development tests/integration/targets/iam_saml_federation/ includes a relatively simple example (but doesn't support check_mode) https://github.com/ansible-collections/amazon.aws/blob/main/tests/integration/targets/ec2_vpc_subnet/tasks/main.yml has some slightly more complex examples Biggest issue is likely to be IAM...

Sorry it's taken so long to come back to this review. I've rebased against the current main branch, and done some docs linting cleanup Only minor thing left that I've...

With regards the tests I'd strongly recommend using the "--docker" option when running them, this allows you to run them in a 'clean' environment which is as close as possible...

+1, assume it's enabled, drop a warning if it fails, and continue cleanly.

@gtie, Thanks for taking the time to submit this suggestion. If anyone was interested in doing this, then I'd recommend a dedicated module. I'm currently working on migrating ec2_elb_lb (aka...