Added functionality to Lambda module for Container based Lambdas

[gen2fish]

SUMMARY

This PR adds functionality to the existing lambda module to create and manage container based lambdas

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

lambda

[ansibullbot]

cc @jillr @markuman @s-hertel @steynovich @tremble @wimnat click here for bot help

[markuman]

@gen2fish Thank you for the PR.

The sanity checks are failing

ERROR: Found 2 validate-modules issue(s) which need to be resolved:
ERROR: plugins/modules/lambda.py:0:0: doc-missing-type: Argument 'image_uri' in argument_spec uses default type ('str') but documentation doesn't define type
ERROR: plugins/modules/lambda.py:0:0: undocumented-parameter: Argument 'image_uri' is listed in the argument_spec, but not documented in the module documentation

Therefore the integrationtests are not running.
You need to expand the documentation section. It would be also helpful if you complete the example section with the usage of the new parameters. And the same for the integrationtest. And at least you'll need a changelog fragment :)

[tremble]

Thanks for your PR.

Tests will currently fail due to missing permissions in CI. A matching PR on https://github.com/mattclay/aws-terminator/tree/master/aws/policy will also be needed.

[gen2fish]

Thanks @tremble, I got unit tests to pass, but the errors in the CI for integration test seem to be around loading an outside collection.

ERROR! couldn't resolve module/action 'community.docker.docker_login'. This often indicates a misspelling, missing collection, or incorrect module path.

I'm failing pretty hard at getting it loaded, is there someplace other than tests/requirements.yml to get that collection loaded?

I'll start working on the pr for ECR stuffs in the terminator, though.

[gen2fish]

It doesn't appear that the integration tests are loading all the collections from tests/requirements.yml into the test environment. I'm not certain where that is set or how to move forward. Any pointers would be appreciated.

I can remove those sections of the integration test if a maintainer would like, but I'm not certain that is the desired outcome.

[gen2fish]

blocked waiting on https://github.com/mattclay/aws-terminator/pull/178

[jillr]

recheck

[gen2fish]

recheck

[alinabuzachis]

@gen2fish It seems sanity of falling because of:

ERROR: Found 1 pep8 issue(s) which need to be resolved: 2275 | 2021-11-22 16:05:06.273885 \| fedora-34 \| ERROR: plugins/modules/lambda.py:438:5: E303: too many blank lines (3)

Could you please address it? Thank you.

[softwarefactory-project-zuul[bot]]

Build failed.

• ansible-test-sanity-docker-devel : SUCCESS in 10m 01s (non-voting)
• ansible-test-sanity-docker-milestone : SUCCESS in 10m 22s
• ansible-test-sanity-docker-stable-2.9 : SUCCESS in 13m 06s
• ansible-test-sanity-docker-stable-2.10 : SUCCESS in 9m 51s
• ansible-test-sanity-docker-stable-2.11 : SUCCESS in 10m 19s
• ansible-test-sanity-docker-stable-2.12 : SUCCESS in 10m 38s
• ansible-test-units-community-aws-python38 : SUCCESS in 8m 18s
• build-ansible-collection : SUCCESS in 7m 52s
• ansible-test-splitter : SUCCESS in 2m 00s
• ansible-test-cloud-integration-aws-py38_0 : FAILURE in 7m 02s
• ansible-test-cloud-integration-aws-py38_1 : SKIPPED
• ansible-test-cloud-integration-aws-py38_2 : SKIPPED
• ansible-test-cloud-integration-aws-py38_3 : SKIPPED
• ansible-test-cloud-integration-aws-py38_4 : SKIPPED
• ansible-test-cloud-integration-aws-py38_5 : SKIPPED
• ansible-galaxy-importer : FAILURE in 4m 28s (non-voting)

[alinabuzachis]

@gen2fish Since the lambda* modules has been migrated to https://github.com/ansible-collections/amazon.aws, could you please re-open this PR against https://github.com/ansible-collections/amazon.aws? Thank you.