Trask Stalnaker

Results 339 comments of Trask Stalnaker

> The question is more about how to make a non-blocking batch span processor I think 💯 will update title of this issue

> FWIW, the spec wording seems to be a bug > > > Export() will never be called concurrently for the same exporter instance. Export() can be called again only...

re-reading the spec now: > Export() will never be called concurrently for the same exporter instance. Export() can be called again only after the current call returns. I'm reading it...

I support! please tag @open-telemetry/java-instrumentation-approvers on your PR and we can discuss specifics there

IIUC, the confusion/request is that `Span.makeCurrent()` doesn't use the `Context` that was passed into `SpanBuilder.setParent(Context)`. @zeitlinger, I would write the above example as ``` Context extractedContext = textMapPropagator.extract(Context.current(), req, EXTRACT_PROPERTIES_FROM_HEADER);...

I think the ask was for `span.makeCurrent()` to put the span into the Context that was passed into `SpanBuilder.setParent(Context)` and then make that resulting Context active. The confusion is that...

just as a reference, here are two places in the java-instrumentation repo where we hack around immutable carriers: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/akka/akka-http-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/akkahttp/client/HttpHeaderSetter.java https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/java-http-client/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/httpclient/HttpHeadersSetter.java

This issue probably belongs in https://github.com/open-telemetry/opentelemetry-java. @anuraaga @jkwatson (since you have powers in both repos) can you move it?

> I noticed this problem too, is this going to get merged? ping @rmfitzpatrick

hi @MariusBrill! this sounds like a good fit for this repo. we just ask that you or someone else sign up to be a "component owner" for the new component....