Thomas Watson comments

Results 234 comments of


                                            Thomas Watson

Ap_Scheduler: initialize _active_loop_rate_hz in loop() and remove check in get_loop_rate_hz()

> I simplified the getters and made them const Looks great! > ```c++ > // this ensures G_Dt is correct, catching startup issues with constructors > // calling the scheduler...

Ap_Scheduler: initialize _active_loop_rate_hz in loop() and remove check in get_loop_rate_hz()

You shol

AP_HAL_Linux: Correcting soc filename size in file detection.

What does `ls /proc/device-tree/` look like on an affected device?

DOC: Unclear how to evaluate using polynomial package

I'm fairly certain `__call__` is what actually does the work when you call it. It should have a reasonable docstring too.

DOC: Unclear how to evaluate using polynomial package

That would be a reasonable docstring. The current one is `Call self as a function.` which doesn't really mean anything. Nowhere on the reference documentation for the `Polynomial` class does...

AP_Scripting: Add set_options and get_options to the Lua SERIAL class

Are there use cases where these options need to be dynamically set?

AP_Scripting: Add set_options and get_options to the Lua SERIAL class

You should be able to set inversion in the `SERIALn_OPTIONS` and not have to do that in the Lua script.

Garbage collect a closure

Just to clarify, by closure, you mean you want to be able to automatically delete exactly those paths printed by `nix-store -qR`? It is confusing why you refer to "live...

AP_Scripting: Fix memory leak in LUA dataflash logging

This PR indeed fixes an error in the accounting which might create that impression, but as far as I can tell there is no actual leak and I would like...

AP_Scripting: Fix memory leak in LUA dataflash logging

Yes, that would show the accounting bug. But there is still no actual leak that I can tell. In any case, there are several other places in this function that...