Kuba Tużnik
Kuba Tużnik
/remove-lifecycle rotten
/remove-lifecycle stale
CA go.mod changes LGTM /approve
> It currently calls `ng.setSize`, which updates the `clusters.provisioning.cattle.io` object and then sets the internal `replicas` of the node group. It's true that it does not wait until the node...
@jbtk thanks for addressing my comments! I feel like we're very close to alignment, let's finalize this so that we can start implementing something. IIUC these are the contentious parts...
> @jbtk thanks for addressing my comments! I feel like we're very close to alignment, let's finalize this so that we can start implementing something. > > IIUC these are...
On a separate note - IMO both this and previous CA/Karpenter API alignment attempts (e.g. https://github.com/kubernetes/kubernetes/pull/124800) turned out to be surprisingly difficult. We seem to frequently discuss things in circles,...
The current proposal LGTM. We got an LGTM from Karpenter and Jordan as well. IMO this is good to merge as soon as the remaining nits from me and Jordan...
Holding for the one remaining discussion: https://github.com/kubernetes/autoscaler/pull/8151#discussion_r2267037122. Feel free to unhold after the discussion is finalized. /lgtm /approve /hold
/remove-lifecycle rotten