Kuba Tużnik
Kuba Tużnik
/assign @towca
I fully get the motivation for this change, but IMO the implementation goes in the wrong direction in terms of readability. Unfortunately CSR is both very convoluted, and critical to...
Hey @wllbo, sorry for the delay, this PR fell off my radar completely :( I've discussed this with the author of the original code, and it seems that the current...
Thank you! /lgtm /approve
/hold /assign @jonathan-innis /assign @gjtempleton /assign @MaciekPytel
Thanks for all the comments @njtran @elmiko @Bryce-Soghigian @jackfrancis @sftim! I think I've either addressed or responded to everything, please let me know if I missed anything.
> Some more feedback @sftim Addressed/responded. > @towca this might be a work in progress. If it is, you can change the PR title to start with “[WIP] ”. What...
@gjtempleton ping for the review
Thanks @chrisnegus, added your suggestions!
@sftim Yes that's right. @gjtempleton @jonathan-innis @MaciekPytel The review has stalled for some time, could you please prioritize?