kubernetes
chore: defork cloud-provider-azure
What type of PR is this?
TODO
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
azure_config.go and azure_client.go are the core changes of this PR. Changes in other files are more of consequences.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Welcome @comtalyst!
It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/autoscaler has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @comtalyst. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
I really like where this is going, don't see any blockers (though would need another round of close review). Would be good to find a way to prove there are no regressions - to what extent do you think the tests cover this?
For config changes, the existing unit tests could be a prove that the delegations are not breaking interface-wise. More unit tests capturing more corner cases will be added as well. I have confidence in those so far.
For service principal token, I think the E2Es are currently the best bet. Some manual long-running tests might help as well. Looking at their code, I don't see if they have real differences from ours at the moment. But not that my eyes should be trusted that much.
@comtalyst: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/test pull-cluster-autoscaler-e2e-azure
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
May also need to check if updates/renames to config/environment variables warrant any updates to readme and/or charts (could be a follow-up).
As discussed, I believe we should delegate all those to cloud-provider-azure docs. We could sweep through the readmes if there is any left to begin with. For now, I left a note in the release notes (in PR description).
Also, I give it backward compatibility for those who wants to use old names for the interface config fields/envs. Included in the release note as well.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: comtalyst, tallaxes, towca
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~cluster-autoscaler/OWNERS~~ [towca]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@comtalyst: #6947 failed to apply on top of branch "cluster-autoscaler-release-1.30":
Applying: chore: defork cloud-provider-azure
Using index info to reconstruct a base tree...
M cluster-autoscaler/cloudprovider/azure/azure_manager.go
M cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
M cluster-autoscaler/go.mod
M cluster-autoscaler/go.sum
Falling back to patching base and 3-way merge...
Auto-merging cluster-autoscaler/go.sum
CONFLICT (content): Merge conflict in cluster-autoscaler/go.sum
Auto-merging cluster-autoscaler/go.mod
CONFLICT (content): Merge conflict in cluster-autoscaler/go.mod
Auto-merging cluster-autoscaler/cloudprovider/azure/azure_manager_test.go
Auto-merging cluster-autoscaler/cloudprovider/azure/azure_manager.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 chore: defork cloud-provider-azure
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherry-pick cluster-autoscaler-release-1.30
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
