tottoto
tottoto
Resolved at #1888.
Centralizing the graceful shutdown implementation and using it at server implementation can split their responsibility and improve the maintainability.
> Can you explain why this is useful? When the `Debug` implementation is not needed, we can use `prost_build::Config::skip_debug()` to skip implementing `Debug`. However as the `Messages` trait requires `Debug`...
> I am preparing a breaking release now. I want to include this PR. Can you solve the merge conflict? Resolved.
I think this is not breaking change as `http` crate is dev-dependency, and `sync_wrapper`'s type is not exposed and the behaviour is not changed from 0.1.
> While reviewing a dependency update for tonic-health I noticed that it contains a binary file: https://diff.rs/tonic-health/0.12.2/0.12.3/src%2Fgenerated%2Fgrpc_health_v1.bin The URL seems to show `Not found`. > In this case I believe...
> Can you point out where exactly it is used. For me it seems like it's just there. You can find it at https://github.com/hyperium/tonic/blob/v0.12.3/tonic-health/src/lib.rs#L33. If you think something is not...
Could you conforms the commit's message to conventional-commits which conventional-changelog bases on, used in this project.
Sounds reasonable to me. It looks needed to be waited until the next release with breaking changes.
Sounds reasonable to me.