tottoto
tottoto
Duplicate of #1649.
After a quick look, it appears that there are some unrelated changes included. Although I have not checked everything, here are some of them: - The version style in `Cargo.toml`...
> I think I feel a particular frustration here because you are the 3rd person to "take a quick look" and provide review comments which are difficult to take significant...
The failed CIs would be fixed in #1674 and #1677.
The failed CIs would be fixed in #1674 and #1677.
The CI failure would be fixed in #1674.
Looks good to me. I would think this simplifies `tonic`'s implementations. As this does not affect the public APIs of generated codes, this seems not to be a breaking change.
Thanks for the feedback. That's exactly what I was thinking of as well. Given the philosophies of the easiness to use, it should be better to keep these APIs. Reverted...
Regarding to `default_constructed_unit_structs` rule, some of them seem not to be detected, but I am not sure the reason. And I think we have other option to fix the warning,...
> Given that all of these seem to be in examples or test code, I don't think making these non-exhaustive is worth it. I understand. Sounds appropriate.