tottoto
tottoto
> As is, I don't think the changes here are a clear improvement. Can you elaborate what points in the existing implementations are clear than this changes? Regarding to #1748,...
Thanks for the explanation. > The previous implementation had a higher-level interface (adding certificates to the root store). This implementation ends up deduplicating the certificate parsing (good) but actually duplicates...
I would think it sounds good to wait for #1727 if possible.
The use case is the case of when already having DER encoded certificates but not using tls-roots. Regarding using `AsRef` it is for API symmetry and the case users do...
https://github.com/hyperium/tonic/pull/1788 is a use case of this change.
With this change, users can enable both `ring` and `aws-lc-rs`, and when they enable both at the same time, users will need to specify which of these they want to...
@LucioFranco The CI failure does not seem to be caused by this pull request's change. I opened #2021 to address it.
Looks good to me too. > If there is interest, I can create a new example in the examples dir to demonstrate grpc-web proxying. I've only tested unary calls locally...
The modules are already nicely separated correspoinding to their roles, this change feels like it breaks that.
`transport::service::tls` module is the utilities used by the channel and server service modules and `transport::tls` is used by the transport wide implementations related to tls.