Eddie Torres

Results 120 comments of Eddie Torres

The following PR needs to be merged to exercise the end to end test: - https://github.com/kubernetes/test-infra/pull/32728

The test failure in `pull-kubernetes-e2e-gce` is expected and can be ignored (graceful node shutdown is not enabled for that job). I tried to disable the test from executing there by...

@rphillips the change introduced in this PR does not alter when volume teardown is initiated. It simply implements a best effort mechanism to wait for teardown to complete before the...

For `pull-kubernetes-e2e-gce` all the failures appear to be flakes - see this previous run (same commit) where only the e2e test implemented in this PR fails: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/125070/pull-kubernetes-e2e-gce/1811767981395415040: ``` Kubernetes e2e...

Thanks all for the reviews. I've decided to remove the e2e test from this PR for 2 reasons: 1. It unblocks progress and allows for merging the fix without being...

> _hmm, it is hard to say now, if the e2e issue was real or indeed a flake._ No changes were made besides removing the e2e test, you can take...

The regex change made in `pull-kubernetes-e2e-gce` ensures that the e2e test implemented in PR 125070 is skipped (graceful node shutdown is not enabled for that job)

@aojea > _the feature does not seem to have e2e tests (only e2e_node)_ That is correct - today, `NodeFeature:GracefulNodeShutdown` does not have any e2e tests, only `e2e_node` tests. The purpose...

@bobbypage, the node specific logic is already covered by `e2e_node` tests as you mention, but we need to validate how the shutdown process interacts with other cluster components like the...